Skip to content

SDL2: enable parallel building#50318

Merged
cpages merged 1 commit intostagingfrom
unknown repository
Nov 13, 2018
Merged

SDL2: enable parallel building#50318
cpages merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 13, 2018

Motivation for this change

enable parallel building, as issue that was triggering build to fail seems to be fixed https://bugzilla.libsdl.org/show_bug.cgi?id=3977

cc @cpages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 13, 2018
@cpages cpages merged commit c74bca5 into NixOS:staging Nov 13, 2018
@ghost
Copy link
Author

ghost commented Nov 14, 2018

@cpages Thanks!

@ghost ghost deleted the sdl2 branch November 14, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants